feat(h5): h5支持中文页面路径名称 #11604
Merged
feat(h5): h5支持中文页面路径名称 #11604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献！🌷🌷🌷 一般 PR 会在一到两周内进行 review，成功合入后会随下一个版本进行发布。 Review 需要耗费大量时间，所以请遵循以下规范，协助我们提高 review 效率🙏🙏🙏
为了更好地进行沟通，请加入 Taro 开发者微信群： |
ZakaryCode
added
A-router
ZakaryCode
requested changes
Apr 14, 2022
| @@ -146,7 +146,7 @@ export class Tabbar implements ComponentInterface { | |||
| const customRoute = this.customRoutes.filter(([, customUrl]) => { | |||
| const pathA = splitUrl(customUrl).path | |||
| const pathB = splitUrl(url).path | |||
| return pathA === pathB | |||
There was a problem hiding this comment.
应该不需要在这里变动，而是 decode 几处 location.pathname 就足够了 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
Web 平台（H5）支持使用中文页面路径名。
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: