Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rn): swiper selectIndex updated when props change #10962

Merged
merged 2 commits into from
Dec 23, 2021
Merged

fix(rn): swiper selectIndex updated when props change #10962

merged 2 commits into from
Dec 23, 2021

Conversation

zhiqingchen
Copy link
Member

这个 PR 做了什么? (简要描述所做更改)

父组件导致组件重新渲染，导致UNSAFE_componentWillReceiveProps 被调用，进而导致swiper调回初始化位置

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

@zhiqingchen zhiqingchen added T-rn Target - 编译到 React Native V-3 Version - 3.x labels Dec 23, 2021
@zhiqingchen zhiqingchen added this to the 3.3.18 milestone Dec 23, 2021
@zhiqingchen zhiqingchen merged commit 0e2439f into NervJS:next Dec 23, 2021
@iambool
Copy link
Collaborator

iambool commented Dec 24, 2021

验证通过

@zhiqingchen zhiqingchen deleted the fix-swiper-circular-selected branch December 24, 2021 04:42
@ZakaryCode ZakaryCode mentioned this pull request Dec 24, 2021
Merged
@taro-bot2 taro-bot2 bot mentioned this pull request Dec 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iChengbo iChengbo iChengbo approved these changes

Assignees
No one assigned
Labels
T-rn Target - 编译到 React Native V-3 Version - 3.x
Projects
None yet
Milestone
3.3.18
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiqingchen @iambool @iChengbo