Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/harmony form #10640

Merged
merged 5 commits into from
Dec 7, 2021
Merged

Feat/harmony form #10640

merged 5 commits into from
Dec 7, 2021

Conversation

crazyonebyone
Copy link
Collaborator

@crazyonebyone crazyonebyone commented Nov 12, 2021

这个 PR 做了什么? (简要描述所做更改)
鸿蒙兼容Form组件

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙应用(harmony)

测试代码:

import React, { Component } from 'react'
import { View, Text, Form, Input, Checkbox, CheckboxGroup } from '@tarojs/components'
import './index.scss'

export default class Index extends Component {

  componentWillMount () {
    console.log('进入主程序')
   }

  componentDidMount () { }

  componentWillUnmount () { }

  componentDidShow () { }

  componentDidHide () { }

  formSubmit(e) {
    console.log('表单提交')
    console.log(JSON.stringify(e.detail))
  }
  formReset(e) {
    console.log('表单重置')
  }
  handleChange () {
    console.log('boxCHange')
  }
  render () {
    return (
      <View className='index'>
        <Form id='formId' className='formClass' onSubmit={this.formSubmit} onReset={this.formReset}>
          <Input type='text' name='userName' value='123'></Input>
          <Input type='submit' value='提交'>提交</Input>
        </Form>

      </View>
    )
  }
}

@taro-bot2
Copy link

taro-bot2 bot commented Nov 12, 2021

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

@crazyonebyone crazyonebyone reopened this Nov 12, 2021
@crazyonebyone crazyonebyone changed the base branch from next to feat/harmony November 12, 2021 08:23
@crazyonebyone crazyonebyone added the T-harmony Target - 编译到 Harmony label Nov 12, 2021
@Chen-jj
Copy link
Contributor

Chen-jj commented Nov 25, 2021

提供一下测试用例

@crazyonebyone
Copy link
Collaborator Author

已提供

@@ -11,6 +11,7 @@ export default createOption({
id: String,
value: String,
type: String,
name: String,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要为其余表单组件也补上 name 属性

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只有input 才支持 name属性,其余没有这个属性

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

radio、checkbox 加一下,其余的表单组件我和鸿蒙侧对一下

@Chen-jj Chen-jj merged commit 794a3f3 into feat/harmony Dec 7, 2021
@Chen-jj Chen-jj deleted the feat/harmony-form branch December 7, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-harmony Target - 编译到 Harmony
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants