Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/harmony interactive api #10453

Merged
merged 14 commits into from
Nov 9, 2021
Merged

Feat/harmony interactive api #10453

merged 14 commits into from
Nov 9, 2021

Conversation

huozhongyi123
Copy link
Collaborator

@huozhongyi123 huozhongyi123 commented Oct 19, 2021 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)
增加适配鸿蒙的交互的api
案例 https://github.com/huozhongyi123/taro-harmony-react/blob/main/src/pages/index/index.jsx
showLoading和hideLoading 目前不支持

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）
  • 鸿蒙（harmony）

@taro-bot2
Copy link

taro-bot2 bot commented Oct 19, 2021

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献！🌷🌷🌷

一般 PR 会在一到两周内进行 review，成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间，所以请遵循以下规范，协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景（非常重要，例如解决了什么问题，该问题如何复现等）
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通，请加入 Taro 开发者微信群：

@huozhongyi123
Copy link
Collaborator Author

@luckyadam @Chen-jj 适配鸿蒙交互api已完成

@huozhongyi123 huozhongyi123 added the T-harmony Target - 编译到 Harmony label Oct 19, 2021
@taro-bot2 taro-bot2 bot mentioned this pull request Oct 23, 2021
Closed
@huozhongyi123
Copy link
Collaborator Author

@Chen-jj 已完成，hidetoast目前方案看着没问题，loading看以后用自定义组件试试

Chen-jj
Chen-jj requested changes Nov 1, 2021
View reviewed changes
packages/taro-harmony/src/apis/interactive/index.ts Outdated Show resolved Hide resolved
packages/taro-harmony/src/apis/interactive/index.ts Outdated Show resolved Hide resolved
packages/taro-harmony/src/apis/interactive/index.ts Outdated Show resolved Hide resolved
packages/taro-harmony/src/apis/interactive/index.ts Outdated Show resolved Hide resolved
packages/taro-harmony/src/apis/interactive/index.ts Outdated Show resolved Hide resolved
packages/taro-harmony/src/apis/interactive/index.ts Outdated Show resolved Hide resolved
packages/taro-harmony/src/apis/interactive/index.ts Outdated Show resolved Hide resolved
Chen-jj
Chen-jj requested changes Nov 4, 2021
View reviewed changes
packages/taro-harmony/src/apis/interactive/index.ts Outdated
duration: 1500,
mask: false,
bottom: '100px',
success: noop,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些方法在 callAsyncSuccess 里已经有判空逻辑，不需要默认值

packages/taro-harmony/src/apis/interactive/index.ts Outdated Show resolved Hide resolved
@taro-bot2 taro-bot2 bot mentioned this pull request Nov 6, 2021
Closed
@Chen-jj Chen-jj merged commit 68af72c into feat/harmony Nov 9, 2021
@Chen-jj Chen-jj deleted the feat/harmony-interactive-api branch November 9, 2021 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chen-jj Chen-jj Chen-jj approved these changes

@luckyadam luckyadam Awaiting requested review from luckyadam

Assignees
No one assigned
Labels
T-harmony Target - 编译到 Harmony
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huozhongyi123 @Chen-jj