Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taro升到3.3.17后，h5上Taro.showModal里面cancelText,cancelColor都变成必填的了，没有就报错 #10949

Closed
lhkg1988 opened this issue Dec 22, 2021 · 3 comments · Fixed by #10950 or #10972
Closed

Taro升到3.3.17后，h5上Taro.showModal里面cancelText,cancelColor都变成必填的了，没有就报错 #10949

lhkg1988 opened this issue Dec 22, 2021 · 3 comments · Fixed by #10950 or #10972
Labels
F-react Framework - React T-h5 Target - 编译到 H5 V-3 Version - 3.x

Comments

@lhkg1988
Copy link

相关平台

H5

浏览器版本: Chrome 96
使用框架: React

复现步骤

Taro升到3.3.17后，h5上Taro.showModal里面cancelText,cancelColor都变成必填的了，没有就报错
7d1249fa0541a3e57dcac421028c7e3

期望结果

保持原来版本的样子，可以正常调用

实际结果

会报错

环境信息

👽 Taro v3.3.17

Taro CLI 3.3.17 environment info:
System:
OS: Windows 10
Binaries:
Node: 14.17.6 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.10 - D:\User\hliu\AppData\Roaming\npm\yarn.CMD
npm: 6.14.15 - C:\Program Files\nodejs\npm.CMD
@taro-bot2 taro-bot2 bot added F-react Framework - React T-h5 Target - 编译到 H5 V-3 Version - 3.x labels Dec 22, 2021
ZakaryCode added a commit that referenced this issue Dec 22, 2021
@ZakaryCode
fix(h5): 修复弹窗默认参数 fix ##10949
b01b84e
@ZakaryCode ZakaryCode mentioned this issue Dec 22, 2021
Merged
2 tasks
ZakaryCode added a commit that referenced this issue Dec 22, 2021
@ZakaryCode
fix(h5): 修复弹窗默认参数 fix ##10949
0c1d2fe
@ZakaryCode ZakaryCode mentioned this issue Dec 23, 2021
Closed
@bobsam
Copy link

bobsam commented Dec 23, 2021

@ZakaryCode 今天会发版解决？我看了一下 我们本地处理不好做

@Mr-sgreen
Copy link

@ZakaryCode 今天会发版解决？我看了一下 我们本地处理不好做

可以先临时劫持下taro弹窗的函数，然后在劫持函数里面判断下有没有传，没有手动传下 或者回退下Taro的版本，taro好像平均都是10天左右一个版本估计没这么快

@bobsam
Copy link

bobsam commented Dec 23, 2021

@ZakaryCode 今天会发版解决？我看了一下 我们本地处理不好做

可以先临时劫持下taro弹窗的函数，然后在劫持函数里面判断下有没有传，没有手动传下 或者回退下Taro的版本，taro好像平均都是10天左右一个版本估计没这么快

难搞啊。。。还是希望官方发吧，感觉不止这个那么简单

@ZakaryCode ZakaryCode mentioned this issue Dec 24, 2021
Merged
@taro-bot2 taro-bot2 bot mentioned this issue Dec 25, 2021
Closed
@ZakaryCode ZakaryCode moved this to Done in H5 Apr 10, 2023
@ZakaryCode ZakaryCode added this to H5 Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
F-react Framework - React T-h5 Target - 编译到 H5 V-3 Version - 3.x
Projects
H5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(h5): api export error NervJS/taro
chore(release): publish 3.3.18 NervJS/taro
3 participants
@lhkg1988 @bobsam @Mr-sgreen