Skip to content

Commit

Permalink
fix(components-rn): change input prop maxLength to maxlength
Browse files Browse the repository at this point in the history
  • Loading branch information
zhiqingchen committed Apr 25, 2021
1 parent b83fd4d commit 54e2178
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export interface InputProps {
password?: boolean;
placeholder?: string;
disabled?: boolean;
maxLength: number;
maxlength?: number;
autoFocus?: boolean;
confirmType: 'done' | 'send' | 'search' | 'next' | 'go';
confirmHold?: boolean;
Expand Down
10 changes: 5 additions & 5 deletions packages/taro-components-rn/src/components/Input/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* ✘ placeholder-style: Only placeholderTextColor(RN).
* - placeholder-class
* ✔ disabled
* ✔ maxLength
* ✔ maxlength
* ✘ cursor-spacing
* - auto-focus
* ✔ focus
Expand Down Expand Up @@ -58,7 +58,7 @@ const keyboardTypeMap: { [key: string]: string } = {
class _Input extends React.Component<InputProps, InputState> {
static defaultProps = {
type: 'text',
maxLength: 140,
maxlength: 140,
confirmType: 'done',
selectionStart: -1,
selectionEnd: -1
Expand Down Expand Up @@ -182,7 +182,7 @@ class _Input extends React.Component<InputProps, InputState> {
password,
placeholder,
disabled,
maxLength,
maxlength,
confirmType,
confirmHold,
cursor,
Expand Down Expand Up @@ -214,7 +214,7 @@ class _Input extends React.Component<InputProps, InputState> {
'password',
'placeholder',
'disabled',
'maxLength',
'maxlength',
'focus',
'confirmType',
'confirmHold',
Expand All @@ -235,7 +235,7 @@ class _Input extends React.Component<InputProps, InputState> {
secureTextEntry={!!password}
placeholder={placeholder}
editable={!disabled}
maxLength={maxLength === -1 ? undefined : maxLength}
maxLength={maxlength === -1 ? undefined : maxlength}
// returnKeyLabel={confirmType}
returnKeyType={confirmType}
blurOnSubmit={!_multiline && !confirmHold}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@ import { InputProps, EventOnLineChange } from '../Input/PropsType'
export interface TextareaProps extends InputProps {
autoHeight?: boolean;
autoFocus?: boolean;
maxlength?: number;
onLineChange?: (evt: EventOnLineChange) => void;
}
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const _Textarea: React.FC<TextareaProps> = (props: TextareaProps) => {
'onLineChange',
'maxlength'
])}
maxLength={maxlength}
maxlength={maxlength}
/>
)
}
Expand Down

0 comments on commit 54e2178

Please sign in to comment.