[Code Enchancement] Support for ovos config #65
Conversation
|
@NeonDaniel please review it, but overall I think I will have to split up pyklatchat modules, so it will be easier to manage |
| @@ -0,0 +1,7 @@ | |||
| import importlib | |||
| import logging | |||
|
|
|||
There was a problem hiding this comment.
Any reason this isn't just from ovos_utils.log import LOG? That also handles the log overrides from config so the combo_lock patching shouldn't be necessary (just addded to default config)
There was a problem hiding this comment.
Any reason this isn't just
from ovos_utils.log import LOG? That also handles the log overrides from config so thecombo_lockpatching shouldn't be necessary (just addded to default config)
I see that in config we only set certain level of those, while I want to disable it completely...
There was a problem hiding this comment.
I think errors or at least exceptions should be shown to debug failures
There was a problem hiding this comment.
I think errors or at least exceptions should be shown to debug failures
Okay, I think I will leave it as is for now, and focus on implementing the features Elon and Richard are asking me for, and will get back to that later
|
I see the automation is failing |
| @@ -0,0 +1,7 @@ | |||
| import importlib | |||
| import logging | |||
|
|
|||
There was a problem hiding this comment.
I think errors or at least exceptions should be shown to debug failures
No description provided.