Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTS and STT Support for PyKlatchat #39

Merged
merged 28 commits into from
Aug 15, 2022
Merged

TTS and STT Support for PyKlatchat #39

merged 28 commits into from
Aug 15, 2022

Conversation

NeonKirill
Copy link
Collaborator

No description provided.

Copy link
Member

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if this is all working. Noted one line that appears to be some leftover test code

services/klatchat_observer/controller.py Outdated Show resolved Hide resolved
chat_client/static/js/speak_utils.js Show resolved Hide resolved
chat_client/static/js/speak_utils.js Show resolved Hide resolved
chat_client/static/js/user_utils.js Outdated Show resolved Hide resolved
chat_client/static/js/user_utils.js Outdated Show resolved Hide resolved
chat_server/sio.py Show resolved Hide resolved
chat_server/sio.py Outdated Show resolved Hide resolved
chat_server/utils/os_utils.py Show resolved Hide resolved
@NeonKirill NeonKirill requested a review from NeonDaniel August 7, 2022 12:17
chat_server/server_utils/db_utils.py Show resolved Hide resolved
@@ -52,6 +53,10 @@ class LanguageSettings:

__excluded_language_codes__ = ['ru', 'eo']

__neon_language_mapping__ = bidict({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably move this handling to Neon Core in the future to deal with ISO 639 codes when we expect BCP 47 ones. There is a method in Lingua Franca to handle this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably move this handling to Neon Core in the future to deal with ISO 639 codes when we expect BCP 47 ones. There is a method in Lingua Franca to handle this

Please refer to that implementation, maybe I could alter that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a get_full_lang_code method. I opened this PR to fill out that list with more known codes.

I think we could validate languages either in the MQ connector or directly in core where we reference languages. The function doesn't do anything if the code is already a full language code or if it isn't a known code

chat_server/utils/sftp_utils.py Show resolved Hide resolved
utils/template_utils.py Show resolved Hide resolved
chat_server/utils/languages.py Show resolved Hide resolved
@NeonKirill NeonKirill requested a review from NeonDaniel August 11, 2022 16:49
@NeonKirill NeonKirill merged commit a510ac8 into dev Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants