-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TTS and STT Support for PyKlatchat #39
Conversation
# Conflicts: # chat_server/app.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good if this is all working. Noted one line that appears to be some leftover test code
@@ -52,6 +53,10 @@ class LanguageSettings: | |||
|
|||
__excluded_language_codes__ = ['ru', 'eo'] | |||
|
|||
__neon_language_mapping__ = bidict({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could probably move this handling to Neon Core in the future to deal with ISO 639 codes when we expect BCP 47 ones. There is a method in Lingua Franca to handle this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could probably move this handling to Neon Core in the future to deal with ISO 639 codes when we expect BCP 47 ones. There is a method in Lingua Franca to handle this
Please refer to that implementation, maybe I could alter that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a get_full_lang_code
method. I opened this PR to fill out that list with more known codes.
I think we could validate languages either in the MQ connector or directly in core where we reference languages. The function doesn't do anything if the code is already a full language code or if it isn't a known code
No description provided.