Fix typo in Helm Charts #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add note to Testing.md
NeonDaniel
added a commit
to NeonDaniel/neon-diana-utils
that referenced
this pull request
Jun 6, 2023
* Refactor and add HTTP Backend Services (NeonGeckoCom#19) * Refactor utils module * Add constants with unit tests * reorg and refactor unit tests * refactor CLI to call standalone functions in module * Update documentation and add HTTP services * Cleanup unit test imports * deprecate convert_docker_compose method improve test coverage * Add glados tts service * Fix indentation in service_mappings.yml Co-authored-by: Daniel McKnight <[email protected]> * Increment Version * Added mimic2 containers to service_mappings.yml (NeonGeckoCom#21) * Added mimic2 containers to service_mappings.yml * Cleanup volume handling Co-authored-by: Daniel McKnight <[email protected]> * Increment Version * Add reference to GH secret creation in docs (NeonGeckoCom#23) Add CLI command to create GH secret spec Update documentation to include GH secret creation Co-authored-by: Daniel McKnight <[email protected]> * Increment Version * Add method to generate TCP service config (NeonGeckoCom#24) * Add method to generate TCP service config * Fix path errors * Update ingress-nginx config handling and documentation * Add utilities to create Ingress and Issuer resource specs with unit tests Update README documentation * Handle config file creation * Resolve missing directory test error * Update `write_kubernetes_spec` output path checks and unit test * Update docs and unit tests to account for updated ingress configuration * Troubleshoot Docker outputs Update documentation * Update tests to handle updated output paths Co-authored-by: Daniel McKnight <[email protected]> * Increment Version * Update GH Automation (NeonGeckoCom#26) * Update release flow to new shared workflows Add license tests Update unit test Python version coverage * Update neon-utils dependency to resolve license test failure * Update neon-utils dependency to resolve unit test failure * Fix typo in dependencies * Increment Version to * Fix path error introduced in NeonGeckoCom#26 (NeonGeckoCom#27) * Increment Version to 0.0.6a6 * Helm charts (NeonGeckoCom#25) * Add Testing.md to describe a local test environment Add Larynx and Mozilla Helm charts * Add remaining HTTP services * Refactor helm charts directory Update libretranslate to use shared template * Finalize HTTP Helm charts * Cleanup http services charts and enable horizontal scaling * Cleanup http ingress labels Add patched nginx ingress resource for TCP services * Working RabbitMQ template with doc updates * Update http services to simplify defined values * Remove patched NGINX ingress patches * Update ingress config in diana-http Update nginx ingress config Add diana-backend chart to deploy HTTP services + rabbitMQ * Implement cert-manager certificates * WIP Refactor of utils to support new Kubernetes configuration * Update backend template to include `diana.yaml` secret Update Helm_Deployment.md docs * Update `base-mq` chart and implement `neon-api-proxy` chart * Update `configure-mq-backend` to include guided generation of `diana.yaml` and GitHub secret for K8s * Add neon-script-parser chart with updated deployment to handle GH secret * Fix typos in neon-script-parser chart and secret deployment spec * Add Brands service * Define mq-services chart Update diana-backend chart to include MQ services * Update CLI and helpers to generate Helm deployment resources Add user config templates Add rabbitMQ config to Helm chart Update Helm docs * Add PVC for Metrics collection * Fix domain handling in K8s deployment Update docs and output files to explain deployment * Update helm chart for better compat. with applied configurations Update documentation WIP updates to handle non-default MQ ports * Revert default domain in backend chart Remove RMQ port overrides from backend chart Add note to ingress chart Use default MQ address/port in CLI to simplify deployment * Update imports and dependencies to remove `neon_utils` * Update deployment templates to handle `image.pullPolicy` config * Add .gitignore with Python defaults + .lock files * Remove Chart.lock * Cleanup helm charts directory * Add libretranslate service and vhost to MQ config * Update kwargs to remove negated bool Clean output directory when building a deployment Helm chart * Add optional config mount in HTTP containers and enable for Libretranslate * Update README documentation * Increment Version to 0.0.6a7 * Fix typo in Helm Charts (NeonGeckoCom#29) * Fix typo in deployment template Add note to Testing.md * Skip failing docker test * Add helm charts to package data * Increment Version to 0.0.6a8 * Testing chart version automation --------- Co-authored-by: Daniel McKnight <[email protected]> Co-authored-by: NeonDaniel <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix typo in deployment template
Add note to Testing.md
Issues
Other Notes