Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.47.4 #1945

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Version 0.47.4 #1945

merged 1 commit into from
Nov 12, 2024

Conversation

fingolfin
Copy link
Member

No description provided.

@@ -13,7 +13,7 @@ RandomExtensions = "fb686558-2515-59ef-acaa-46db3789a887"
SHA = "ea8e919c-243c-51af-8825-aaa63cd721ce"

[compat]
AbstractAlgebra = "0.43.6"
AbstractAlgebra = "0.43.9"
FLINT_jll = "^300.100.100"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you need this bump for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are various recent changes we made in AA and Nemo that are tightly interlocked and I am worried about combinations we never really tested well being put out there. That said, in the end, shrug

Copy link
Collaborator

@lgoettgens lgoettgens Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine for me, let's just keep it in. I was just interested if you had any concrete reason

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.91%. Comparing base (9b83a72) to head (2db5e62).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1945   +/-   ##
=======================================
  Coverage   87.90%   87.91%           
=======================================
  Files          99       99           
  Lines       36366    36366           
=======================================
+ Hits        31968    31970    +2     
+ Misses       4398     4396    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens enabled auto-merge (squash) November 12, 2024 19:33
@lgoettgens lgoettgens merged commit 80d1172 into master Nov 12, 2024
24 checks passed
@lgoettgens lgoettgens deleted the mh/v0.47.4 branch November 12, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants