Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more generic is_trivial #1905

Merged
merged 2 commits into from
Nov 15, 2024
Merged

feat: more generic is_trivial #1905

merged 2 commits into from
Nov 15, 2024

Conversation

thofma
Copy link
Member

@thofma thofma commented Nov 15, 2024

As suggested by @YueRen. All rings implement one and is_zero, but many don't or cannot implement characteristic.

Will make #1857 less breaking.

As suggested by @YueRen. Most rings implement `==`, but not `characteristic`.
src/Rings.jl Outdated Show resolved Hide resolved
Co-authored-by: Lars Göttgens <[email protected]>
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.17%. Comparing base (9d38ede) to head (82022c2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1905   +/-   ##
=======================================
  Coverage   88.16%   88.17%           
=======================================
  Files         120      120           
  Lines       30296    30296           
=======================================
+ Hits        26711    26712    +1     
+ Misses       3585     3584    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fingolfin
Copy link
Member

So how about also extending the default characteristic method to have this test? I.e. it could return 1 if one(R) == zero(R)

@thofma
Copy link
Member Author

thofma commented Nov 15, 2024

I think there is no default characteristic method. Someone could add one later, but I would like to get this PR here merged first.

@thofma thofma merged commit 25a7ea8 into master Nov 15, 2024
29 checks passed
@thofma thofma deleted the th/istrivial branch November 15, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants