Add is_lower_triangular, tweak is_upper_triangular #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1430 +/- ##
==========================================
- Coverage 84.60% 84.44% -0.17%
==========================================
Files 109 109
Lines 29322 29339 +17
==========================================
- Hits 24809 24774 -35
- Misses 4513 4565 +52
... and 24 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Why is the argument |
The old is_upper_triangular did something strange; it reported matrices as upper triangular that I would not consider to be, e.g. [ 1 0 0 ; 0 0 1 ; 1 0 1 ]
fingolfin
force-pushed
the
mh/is_upper_lower_triangular
branch
from
17ef3f5
to
da75512
Compare
|
Oops, that was meant to be |
lgoettgens
approved these changes
Sep 13, 2023
lgoettgens
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old is_upper_triangular did something strange; it reported
matrices as upper triangular that I would not consider to be, e.g.
[ 1 0 0 ; 0 0 1 ; 1 0 1 ]