Enhance *poly*_type methods #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
force-pushed
the
mh/more-poly-type
branch
from
95383b7
to
cf1f9de
Compare
They all now accept both rings, ring elements, or their types. Also fix the docstrings
fingolfin
force-pushed
the
mh/more-poly-type
branch
from
cf1f9de
to
5e4a765
Compare
Codecov Report
@@ Coverage Diff @@
## master #1303 +/- ##
==========================================
+ Coverage 85.72% 85.76% +0.03%
==========================================
Files 102 102
Lines 27871 27873 +2
==========================================
+ Hits 23892 23904 +12
+ Misses 3979 3969 -10
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
julien-schanz
pushed a commit
to julien-schanz/AbstractAlgebra.jl
that referenced
this pull request
Mar 28, 2023
They all now accept both rings, ring elements, or their types. Also fix the docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They all now accept both rings, ring elements, or their types. Also fix the docstrings.
Motivated by Nemocas/Nemo.jl#1423.