Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ngens for FreeAssAlgebra #1295

Merged
merged 2 commits into from
Mar 24, 2023
Merged

add ngens for FreeAssAlgebra #1295

merged 2 commits into from
Mar 24, 2023

Conversation

lgoettgens
Copy link
Collaborator

Closes #1294

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #1295 (712bdff) into master (8aefeec) will increase coverage by 0.03%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master    #1295      +/-   ##
==========================================
+ Coverage   85.51%   85.55%   +0.03%     
==========================================
  Files         102      102              
  Lines       27987    27973      -14     
==========================================
- Hits        23932    23931       -1     
+ Misses       4055     4042      -13     
Impacted Files Coverage Δ
src/Rings.jl 51.78% <0.00%> (-2.94%) ⬇️
src/generic/MPoly.jl 94.97% <ø> (+0.05%) ⬆️
src/generic/NCPoly.jl 61.00% <ø> (-0.96%) ⬇️
src/generic/Poly.jl 98.75% <ø> (-0.03%) ⬇️
src/NCRings.jl 89.13% <66.66%> (-1.78%) ⬇️
src/MPoly.jl 78.30% <90.00%> (+0.82%) ⬆️
src/AbstractAlgebra.jl 51.56% <100.00%> (ø)
src/NCPoly.jl 90.05% <100.00%> (+0.64%) ⬆️
src/Poly.jl 93.12% <100.00%> (+0.27%) ⬆️
src/generic/FreeAssAlgebra.jl 99.70% <100.00%> (+<0.01%) ⬆️
... and 1 more

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thofma thofma merged commit 118159b into Nemocas:master Mar 24, 2023
@thofma
Copy link
Member

thofma commented Mar 24, 2023

Thanks!

julien-schanz pushed a commit to julien-schanz/AbstractAlgebra.jl that referenced this pull request Mar 28, 2023
* add `ngens` for `FreeAssAlgebra`

* add `ngens` test for `FreeAssAlgebra`
@lgoettgens lgoettgens deleted the patch-2 branch March 31, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no ngens for FreeAssAlgebra
2 participants