Fix bug in universal polynomial ring #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 17, 2023
|
I thought Dan already fixed multivariates in FLINT to work with zero variables. Are you saying that this is broken throughout FLINT, or are there possibly just some isolated bugs that we can fix on the FLINT side? |
|
Ah, did he? If so, he did not remove the check in Nemo. Let me check. |
Not all multivariate polynomial rings can be constructed with zero indeterminants (e.g. all ring coming from flint). Thus we always use a generic polynomial ring underpinning the universal one.
Codecov Report
@@ Coverage Diff @@
## master #1286 +/- ##
==========================================
- Coverage 85.53% 85.50% -0.03%
==========================================
Files 102 102
Lines 27987 27987
==========================================
- Hits 23938 23931 -7
- Misses 4049 4056 +7
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I will merge this for now. Allowing flint rings is a bigger project. |
julien-schanz
pushed a commit
to julien-schanz/AbstractAlgebra.jl
that referenced
this pull request
Mar 28, 2023
Not all multivariate polynomial rings can be constructed with zero indeterminants (e.g. all ring coming from flint). Thus we always use a generic polynomial ring underpinning the universal one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all multivariate polynomial rings can be constructed with
zero indeterminants (e.g. all ring coming from flint).
Thus we always use a generic polynomial ring underpinning the
universal one.
Fixes oscar-system/Oscar.jl#2076
I cannot test it here.