Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added custom Headers/Cookies #85

Merged
merged 5 commits into from
Nov 18, 2020
Merged

added custom Headers/Cookies #85

merged 5 commits into from
Nov 18, 2020

Conversation

s0i37
Copy link

@s0i37 s0i37 commented Nov 15, 2020

No description provided.

@s0i37 s0i37 mentioned this pull request Nov 15, 2020
@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #85 (0357813) into develop (2346c53) will increase coverage by 0.64%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #85      +/-   ##
===========================================
+ Coverage    91.95%   92.60%   +0.64%     
===========================================
  Files           35       35              
  Lines         2076     2082       +6     
===========================================
+ Hits          1909     1928      +19     
+ Misses         167      154      -13     
Impacted Files Coverage Δ
dirhunt/sessions.py 98.03% <77.77%> (-0.92%) ⬇️
dirhunt/crawler.py 84.12% <100.00%> (ø)
dirhunt/processors.py 90.42% <0.00%> (+0.70%) ⬆️
dirhunt/tests/test_sessions.py 100.00% <0.00%> (+1.25%) ⬆️
dirhunt/tests/test_sources.py 100.00% <0.00%> (+1.28%) ⬆️
dirhunt/tests/test_exceptions.py 100.00% <0.00%> (+6.66%) ⬆️
dirhunt/_compat.py 79.16% <0.00%> (+29.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2346c53...7e9618e. Read the comment docs.

@Nekmo Nekmo self-requested a review November 15, 2020 16:02
@Nekmo Nekmo self-assigned this Nov 15, 2020
@Nekmo
Copy link
Owner

Nekmo commented Nov 15, 2020

Hi @s0i37 ,

Thanks for your contribution! I just found a mistake. In Python you should not use dynamic values in parameters. Here is more info:

https://codefellows.github.io/sea-f2-python-sept14/session05.html#mutables-as-default-arguments

After this error I could include your changes. It would also be great if you include tests.

Thanks again!

@s0i37
Copy link
Author

s0i37 commented Nov 16, 2020

I have fixed

@Nekmo Nekmo merged commit edd9315 into Nekmo:develop Nov 18, 2020
@Nekmo
Copy link
Owner

Nekmo commented Nov 18, 2020

Merged! Thank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants