Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean profile/translation path logic #1083

Closed
wants to merge 2 commits into from
Closed

Clean profile/translation path logic #1083

wants to merge 2 commits into from

Conversation

Ilses
Copy link
Contributor

@Ilses Ilses commented Jul 27, 2016

Path variables re-structured as:

ProfilePath = \Release\Profile\
ProfileConfigPath = \Release\Profile\Config\
GeneralConfigPath = \Release\Config

Path variables available in ILogicSettings
Add [JsonIgnores] to path variables

Bugfix: config.json should be saved during first run case
Make first run messages more explicit

Ilses added 2 commits July 27, 2016 16:43
@Ilses
Clean up path logic for profile config. Translations now in general
4826ebb 
config folder folder, not per-profile!

Bugfix: config.json should be saved during first run case
@Ilses
More explicit first-start notification.
8b9e3c7
@Ilses Ilses changed the title Clean profile logic Clean profile/translation path logic Jul 27, 2016
@maximegmd
Copy link
Contributor

I like this but merge conflict :(

@5andr0 5andr0 mentioned this pull request Jul 28, 2016
Merged
@Ilses
Copy link
Contributor Author

Ilses commented Jul 28, 2016 •
edited
Loading

I'll fix it once latest master is stable.

Edit: I think 5andr0's PR supersedes this on.

@Ilses
Copy link
Contributor Author

Ilses commented Jul 28, 2016

New version looks pretty good; closing this one.

@Ilses Ilses closed this Jul 28, 2016
@Ilses Ilses deleted the clean-profile-logic branch July 28, 2016 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Client Action Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ilses @maximegmd