Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes (Game version 0.10.29.22010) #665

Merged
merged 5 commits into from
Mar 23, 2024

Conversation

starfi5h
Copy link
Collaborator

0.10.29.22010 Fixes:

  • Fix error when activating super nova in the turret window
  • Fix desync of dyson sphere when client joins the game

0.10.29.21950 Fixes:

  • Fix "Power Intercepted by dark fog hive" doesn`t get synced to client
  • Attempt to fix base enemyId doesn't sync when relay creating it in client
    NRE in EnemyDFGroundSystem.KeyTickLogic (System.Int64 time);(IL_0929)
  • Try to avoid index out of range exception of combatStatId when client move to a planet of another system.
    IndexOutOfRangeException in ConstructionSystem.DetermineLaunch
    Those combat stat ids may exceed range because client can't receive combat events of other systems.

Copy link
Contributor

@antfightclub antfightclub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I happened to be looking into this when you added this PR. The desync fix seems good to me - I tested it on my machine and it worked.

@@ -0,0 +1,17 @@
namespace NebulaModel.Packets.Combat;

public class CombatStatFullHptPacket
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be CombatStatFullHpPacket or is the t intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, this is a typo

@starfi5h starfi5h merged commit 4d6bfcb into NebulaModTeam:master Mar 23, 2024
2 checks passed
@starfi5h starfi5h deleted the pr-fix22010 branch March 23, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants