-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major cleanup #615
Merged
PhantomGamers
merged 21 commits into
NebulaModTeam:master
from
PhantomGamers:cleanup-pr
Dec 15, 2023
Merged
Major cleanup #615
PhantomGamers
merged 21 commits into
NebulaModTeam:master
from
PhantomGamers:cleanup-pr
Dec 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only patcher requires targeting net472 for its transpiler patches
other projects depend on libs that target net framework
whoops
apparently the auto getter only functionality doesn't work properly
gracefully handle cases where the chatwindow component fails to load
add missing null check
update link for com.kyub.emojisearch dependency
Some issues regarding the chat:
|
missed these on the previous pass
starfi5h
approved these changes
Dec 15, 2023
starfi5h
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes in this PR.
This PR will of course break compatibility with any plugin that is using the API, but since tomorrow's update is bound to break most plugins anyway, and I'm sure we'll have to do more breaking changes to the API, I think this is a good time to do this.