Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major cleanup #615

Merged
merged 21 commits into from
Dec 15, 2023
Merged

Major cleanup #615

merged 21 commits into from
Dec 15, 2023

Conversation

PhantomGamers
Copy link
Collaborator

@PhantomGamers PhantomGamers commented Dec 14, 2023

Major changes in this PR.

  • Updated .editorconfig to latest config from roslyn repo https://github.com/dotnet/roslyn/blob/fd3194f093806a6b2577a45aa89b0fd60658eee2/.editorconfig
  • Reformatted sln with IDE
  • Reworked much of the code base to use modern C# features
  • Removed a lot of code nesting by inverting if statements
  • Swapped target framework on the nebula mod api to netstandard2.0 so that it is compatible with plugins that target either net standard or net framework
  • Fixed many namespaces so that they match the directory that they are in

This PR will of course break compatibility with any plugin that is using the API, but since tomorrow's update is bound to break most plugins anyway, and I'm sure we'll have to do more breaking changes to the API, I think this is a good time to do this.

@PhantomGamers PhantomGamers marked this pull request as ready for review December 15, 2023 02:46
@starfi5h
Copy link
Collaborator

Some issues regarding the chat:

  1. Notify messages when login/logoff create an error
ArgumentOutOfRangeException: Exception of type 'System.ArgumentOutOfRangeException' was thrown.
Parameter name: messageType
Actual value was SystemInfoMessage.
NebulaWorld.MonoBehaviours.Local.Chat.ChatWindow.SendLocalChatMessage (System.String text, NebulaModel.DataStructures.Chat.ChatMessageType messageType);(0)
NebulaWorld.MonoBehaviours.Local.Chat.ChatManager.SendChatMessage (System.String text, NebulaModel.DataStructures.Chat.ChatMessageType messageType);(0)
NebulaWorld.SimulatedWorld.SendChatMessage (System.String text, NebulaModel.DataStructures.Chat.ChatMessageType messageType);(0)
NebulaWorld.SimulatedWorld.SpawnRemotePlayerModel (NebulaAPI.GameState.IPlayerData playerData);(0)
NebulaWorld.SimulatedWorld.OnPlayerJoinedGame (NebulaAPI.GameState.INebulaPlayer player);(0)
NebulaNetwork.PacketProcessors.Session.SyncCompleteProcessor.ProcessPacket (NebulaModel.Packets.Session.SyncComplete packet, NebulaModel.Networking.NebulaConnection conn);(0)
  1. Notify now has a dark background
    image

@PhantomGamers PhantomGamers merged commit efda4d8 into NebulaModTeam:master Dec 15, 2023
2 checks passed
@PhantomGamers PhantomGamers deleted the cleanup-pr branch December 15, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants