Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save game loading issues #244

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Fix save game loading issues #244

merged 1 commit into from
Apr 28, 2021

Conversation

hubastard
Copy link
Collaborator

@hubastard hubastard commented Apr 28, 2021

This PR fixes #242 and #243, which are the issues that we had where reconnecting players was sometimes joining as new players or on another planet.

We had 2 main issues:

  1. We were not loading the server save file when we were hosting a game from the Load Game Window which was causing all the players to join with no player data. (This was not occurring if the host stayed in game while the clients reconnected)
  2. The other issue with the players that were spawning on another planet was caused by the fact that we were not handling the save game loading of AutoSaves properly. So we were always reloading the last autosave instead of the actually loading the game that the host had chosen in the Load Game Window.

This PR also fixes the AutoSave rotation that was not handled previously and I also removed the Host button from the Esc menu.

@hubastard
Copy link
Collaborator Author

I will close it right now to make sure that this fix is available as soon as possible. But if you comments you can add them and I will fix them in a subsequent PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants