Ip adress sanitization for MP Menu screen #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pGlase
changed the title
Mushroom
suggested changes
Apr 19, 2021
| @@ -171,6 +171,18 @@ private static void OnJoinGameButtonClick() | |||
| string ip = parts[0]; | |||
| int port; | |||
|
|
|||
| //remove copy and paste mistakes and update the textbox to prevent user confusion in case of invalid ip address | |||
| ip = SanitizeIpAddressString(ip); | |||
There was a problem hiding this comment.
I think using String.Trim() is probably better than a new function here
There was a problem hiding this comment.
Trim is identical to Trim(whitespace)
Mushroom
approved these changes
Apr 19, 2021
hubastard
approved these changes
Apr 19, 2021
Therzok
reviewed
Apr 19, 2021
| @@ -171,6 +171,18 @@ private static void OnJoinGameButtonClick() | |||
| string ip = parts[0]; | |||
| int port; | |||
|
|
|||
| //remove copy and paste mistakes and update the textbox to prevent user confusion in case of invalid ip address | |||
| ip = ip.Trim('\r', '\n', '\t', ' '); | |||
There was a problem hiding this comment.
These are all already considered whitespace by c#
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After being annoyed by Copy&Paste errors when copying from Discord i figured I could add this as an entry exercise.
Maybe this is a good idea to prevent A) Crashes on invalid IPs and B) Give at least a little feedback about IPv4 only.
Please let me know if this is useable for the project, I am usually a C++ dev.