Address comments

NebulaModTeam · Jul 9, 2023 · 69d2c04 · 69d2c04
1 parent 67540b2
commit 69d2c04
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/NebulaPatcher/Patches/Dynamic/UIGalaxySelect_Patch.cs b/NebulaPatcher/Patches/Dynamic/UIGalaxySelect_Patch.cs
@@ -48,7 +48,7 @@ public static void _OnOpen_Postfix(UIGalaxySelect __instance)
                         "Note that when using GalacticScale 2 this process can take a bit longer.\n\n" +
                         "By clicking a planet while having its detail panel open you will set it as your birth planet.\n" +
                         "By clicking into outer space you will go one detail level up. Scroll to zoom in/out. Press Alt to see star names.\n\n" +
-                        "We hope you enjoy this new feature!";
+                        "Alt + ~ can open in-game chat. We hope you enjoy this new feature!";
 
                     InGamePopup.ShowInfo("The Lobby".Translate(),
                         message,

diff --git a/NebulaWorld/Chat/ChatLinks/CopyTextChatLinkHandler.cs b/NebulaWorld/Chat/ChatLinks/CopyTextChatLinkHandler.cs
@@ -16,7 +16,7 @@ public void OnClick(string data)
 
         public void OnHover(string data, ChatLinkTrigger trigger, ref MonoBehaviour tipObject)
         {
-            if (!data.Equals(""))
+            if (!string.IsNullOrEmpty(data))
             {
                 UpdateTip(trigger, ref tipObject);
             }
@@ -51,7 +51,7 @@ private static void UpdateTip(ChatLinkTrigger trigger, ref MonoBehaviour tipObje
                 buttonTip.SetTip(false, "Copy".Translate(), "Click to copy to clipboard".Translate(), Corner, offset, 0, rect, "", "");
             }
 
-            if (buttonTip != null && buttonTip.isActiveAndEnabled && !buttonTip.titleComp.Equals("Copy"))
+            if (buttonTip.isActiveAndEnabled && !buttonTip.titleComp.text.Equals("Copy"))
             {
                 buttonTip.SetTip(false, "Copy".Translate(), "Click to copy to clipboard".Translate(), Corner, offset, 0, rect, "", "");
             }

diff --git a/NebulaWorld/Chat/ChatLinks/NavigateChatLinkHandler.cs b/NebulaWorld/Chat/ChatLinks/NavigateChatLinkHandler.cs
@@ -25,7 +25,7 @@ public void OnClick(string data)
         }
         public void OnHover(string data, ChatLinkTrigger trigger, ref MonoBehaviour tipObject)
         {
-            if (!data.Equals(""))
+            if (!string.IsNullOrEmpty(data))
             {
                 UpdateTip(trigger, ref tipObject);
             }
@@ -60,7 +60,7 @@ private static void UpdateTip(ChatLinkTrigger trigger, ref MonoBehaviour tipObje
                 buttonTip.SetTip(false, "Navigate".Translate(), "Click to create a navigate line to the target.".Translate(), 2, offset, 0, rect, "", "");
             }
 
-            if (buttonTip != null && buttonTip.isActiveAndEnabled && !buttonTip.titleComp.Equals("Navigate"))
+            if (buttonTip.isActiveAndEnabled && !buttonTip.titleComp.text.Equals("Navigate"))
             {
                 buttonTip.SetTip(false, "Navigate".Translate(), "Click to create a navigate line to the target.".Translate(), 2, offset, 0, rect, "", "");
             }
@@ -69,7 +69,7 @@ private static void UpdateTip(ChatLinkTrigger trigger, ref MonoBehaviour tipObje
 
         public string GetIconName(string data)
         {
-            return "";
+            return string.Empty;
         }
         public string GetDisplayRichText(string data)
         {

diff --git a/NebulaWorld/Chat/ChatLinks/SignalChatLinkHandler.cs b/NebulaWorld/Chat/ChatLinks/SignalChatLinkHandler.cs
@@ -77,7 +77,7 @@ public string GetIconName(string data)
         public string GetDisplayRichText(string data)
         {
             int signalId = GetSignalId(data);
-            if (signalId <= 0) return "";
+            if (signalId <= 0) return string.Empty;
 
             return $"<link=\"signal {signalId}\">[<sprite name=\"{signalId}\"> <color=\"green\">{ProtoUtils.GetSignalDisplayName(signalId)}</color>]</link>";
         }