Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence hardware issues from Sentry #84

Merged
merged 3 commits into from
Jan 10, 2022

Conversation

Kerrryu
Copy link

@Kerrryu Kerrryu commented Jan 10, 2022

Issue

How
Changed #81 and #80 to log as warnings to silence them from displaying on Sentry. After discussing this further we have come to the conclusion that these issues are more than likely just hardware issues which shouldn't be recorded in Sentry.

Checklist

  • Cleaned up commit history (rebase!)
  • Thought about variable and method names

@Kerrryu Kerrryu requested a review from a team as a code owner January 10, 2022 05:40
@Kerrryu Kerrryu changed the title Convert error to warning to prevent duplicating errors Silence hardware issues from Sentry Jan 10, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Kerrryu Kerrryu merged commit 8aaee4a into master Jan 10, 2022
@Kerrryu Kerrryu deleted the sebastianmaj/remove-duplicate-error branch January 10, 2022 14:07
Jonzky added a commit to Jonzky/hm-pktfwd that referenced this pull request Jan 12, 2022
Silence hardware issues from Sentry (NebraLtd#84)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants