add modified chip_id.c

[shawaj]

Why

enable us to determine if the chipset is sx1302 or sx1303

How

add a modified version of chip_id.c that allows us to check the chip ID (0x00 or 0x02 for sx1302 and 0x03 for sx1303)

References

#56
Lora-net/sx1302_hal#60

[marvinmarnold]

Makes sense. Can you confirm that I'm understanding this correctly.

1. These changes are based on the 2.1 release of our forked sx1302_hal repo, with some new code you wrote by hand. This is the diff:

diff 2.1.txt pull-request.txt 
39a40
> #include "loragw_sx1302.h"
81a83
>     sx1302_model_id_t model_id;
197a200,207
>     }
> 
>     /* get the concentrator chip model */
>     x = sx1302_get_model_id(&model_id);
>     if (x != LGW_HAL_SUCCESS) {
>         printf("ERROR: failed to get concentrator chip model\n");
>     } else {
>         printf("\nINFO: concentrator chip model ID: 0x%02X\n", model_id);

2. Additional work will need to be done to update the python chip detection to support this new logic.

FYI I'm making progress with hm-pktfwd refactor. I'm finishing up the Dockerfile and sx1302 related logic: https://github.com/NebraLtd/hm-pktfwd/tree/marvinmarnold/total-refactor

[shawaj]

@marvinmarnold yes that's correct. It adds that detection for the chip Id, and In the dockerfile / compile script it pulls in the new files and builds with the new function.

As you say, this isn't picked up in the python code anywhere, and currently isn't actually needed for anything in particular (sx1302 and 3 can use the same config files, however we may want to make adjustments to the rssi offset and LUTs in the future potentially based on further testing, at which point we would need to be able to tell the difference).

I just thought it would be useful to be able to more easily detect the chip variant for debugging of any software or hardware issues in the future.

We don't have any sx1302/sx1303 based modules out in the field currently so it's more for the future than right now.

Currently the only units we have shipped use the sx1301

[shawaj]

Also, on a side note this relates to #23

It's worth keeping an eye on Lora-net/sx1302_hal#58 also as this may remove the need for these "fixes" in future as their current purpose is to remove the hard coded temperature sensor and replace it with a fixed temp