Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework "connected to blockchain" status #74

Closed
shawaj opened this issue Jul 10, 2021 · 3 comments
Closed

Rework "connected to blockchain" status #74

shawaj opened this issue Jul 10, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request needs triage

Comments

@shawaj
Copy link
Member

shawaj commented Jul 10, 2021

Helium are updating the "connected" metric in p2p_status to change "connected" to "well-connected" to reflect the fact that in principle 1 connection means it is connected but this check is really meant to determine if it has a good connection.

They will also add a "sessions" count as well.

We need to update the diagnostics to accommodate these changes once they are merged helium/miner#868

@marvinmarnold marvinmarnold added the enhancement New feature or request label Aug 5, 2021
@shawaj
Copy link
Member Author

shawaj commented Aug 11, 2021

Previous output from miner info p2p_status

/opt/miner # miner info p2p_status
+---------+------+
|  name   |result|
+---------+------+
|connected| yes  |
|dialable | yes  |
|nat_type | none |
| height  |961304|
+---------+------+

Current output from latest

/opt/miner # miner info p2p_status
+--------------+------+
|     name     |result|
+--------------+------+
|well-connected| yes  |
|   sessions   |  12  |
|   dialable   | yes  |
|   nat_type   | none |
|    height    |961300|
+--------------+------+

This is a breaking change - relates to NebraLtd/helium-miner-software#110 (comment)

Error message:

 diagnostics  Traceback (most recent call last):
 diagnostics    File "/opt/main.py", line 404, in <module>
 diagnostics      main()
 diagnostics    File "/opt/main.py", line 311, in main
 diagnostics      if int(diagnostics['MH']) > (int(diagnostics['BCH']) - 500):
 diagnostics  ValueError: invalid literal for int() with base 10: 'none'

shawaj added a commit that referenced this issue Aug 11, 2021
quick and dirty temporary fix for #74
shawaj added a commit to NebraLtd/helium-miner-software that referenced this issue Aug 11, 2021
bump diagnostics version in relation to NebraLtd/hm-diag#74 and #110 (comment)
shawaj added a commit to NebraLtd/hm-config that referenced this issue Aug 12, 2021
bump for miner well-connected issues described in NebraLtd/hm-diag#74
@shawaj
Copy link
Member Author

shawaj commented Aug 12, 2021

See latest 5 commits in https://github.com/NebraLtd/hm-diag/tree/local-dev-environment for (quick and dirty) fix

@robputt
Copy link
Contributor

robputt commented Feb 1, 2023

This is largely irrelevant since miners no longer sync chain, also soon with SOL move Oracles will use grpc to rust based miner deprecating the old erlang miner.

@robputt robputt closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage
Projects
None yet
Development

No branches or pull requests

4 participants