-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes parsing from latest GA release #65
Conversation
@vpetersson probably better to put this onto this branch instead of master https://github.com/NebraLtd/hm-config/tree/fix_handler_typeerror Master has lots of untested changes |
Oh good shout. Let me take a closer look. I thought we were running on master. |
@vpetersson we are running on a really old master. Actually, on that branch you will also need to revert my latest commits |
Actually, I |
Ah ok, well if it works it works! |
Need to bump bluez to rpt2 as in #60 |
Oh and the variant definitions file too... |
One thing at the time @shawaj. Let's fix this particular thing first. |
@vpetersson the docker images won't build unless you fix those... |
Ah ok. Just looked at the logs. |
Actually. I was wrong. There are a lot of changes in master. |
Ok looking closer, these are just lint fixes really. Not too worried about deploying them. Let's get this to pass and merge it in. Then deploy it to testnet. |
Why
Fixes parsing issue from latest GA release
How
Manually tested on TestNet miner.
References
#63