Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes parsing from latest GA release #65

Merged
merged 4 commits into from
Aug 20, 2021
Merged

Fixes parsing from latest GA release #65

merged 4 commits into from
Aug 20, 2021

Conversation

vpetersson
Copy link
Contributor

Why
Fixes parsing issue from latest GA release

How
Manually tested on TestNet miner.

References
#63

@vpetersson vpetersson requested a review from a team as a code owner August 20, 2021 10:19
@shawaj
Copy link
Member

shawaj commented Aug 20, 2021

@vpetersson probably better to put this onto this branch instead of master https://github.com/NebraLtd/hm-config/tree/fix_handler_typeerror

Master has lots of untested changes

@vpetersson
Copy link
Contributor Author

@vpetersson probably better to put this onto this branch instead of master https://github.com/NebraLtd/hm-config/tree/fix_handler_typeerror

Master has lots of untested changes

Oh good shout. Let me take a closer look. I thought we were running on master.

@shawaj
Copy link
Member

shawaj commented Aug 20, 2021

@vpetersson we are running on a really old master.

Actually, on that branch you will also need to revert my latest commits

@vpetersson
Copy link
Contributor Author

@vpetersson we are running on a really old master

Actually, I diff'd master against what we're running on the miners, and they're just cosmetic changes really.

@shawaj
Copy link
Member

shawaj commented Aug 20, 2021

I think if you just revert this change - bfb80d4 on that branch then it's essentially the current one.

Or roll back to 61b77e8 and then add your changes to that on a new branch

@shawaj
Copy link
Member

shawaj commented Aug 20, 2021

Ah ok, well if it works it works!

@shawaj
Copy link
Member

shawaj commented Aug 20, 2021

Need to bump bluez to rpt2 as in #60

@shawaj
Copy link
Member

shawaj commented Aug 20, 2021

Oh and the variant definitions file too...

@vpetersson
Copy link
Contributor Author

One thing at the time @shawaj. Let's fix this particular thing first.

@shawaj
Copy link
Member

shawaj commented Aug 20, 2021

One thing at the time @shawaj. Let's fix this particular thing first.

@vpetersson the docker images won't build unless you fix those...

@vpetersson
Copy link
Contributor Author

Ah ok. Just looked at the logs.

@vpetersson
Copy link
Contributor Author

Actually. I was wrong. There are a lot of changes in master.

@vpetersson
Copy link
Contributor Author

Ok looking closer, these are just lint fixes really. Not too worried about deploying them. Let's get this to pass and merge it in. Then deploy it to testnet.

@vpetersson vpetersson merged commit a418ee7 into master Aug 20, 2021
@shawaj shawaj deleted the parse-fixer branch August 20, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants