-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Ledger HW wallet #424
Open
gabrielKerekes
wants to merge
129
commits into
NeblioTeam:master
Choose a base branch
from
vacuumlabs:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix change outputs - fix transactions with multiple inputs (inputs could have different order than UTxOs) - properly gather signature paths for all inputs (although there can only be one signature path) - change/signature paths are not hardcoded anymore - transactions should work properly
- add hidapi packages to README - revert `macdeployqtplus` `-verbose 3` to `-verbose 1` - remove unused `CPubKey.SetRaw()` - remove TODO comment remained - remove unused Bip32Path string constructor - add empty line to `wallet.pro` to reduce unnecessary changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Ledger support into the Neblio wallet app. Here's a couple of important notes:
build_scripts/CompileBoost-Linux.py
seemed to be broken - the simlink toboost_build
dir was not being created correctly - so we fixed the boost compile script.neblioteam/nebliod-build-ccache
container to install hidapi dependencies and upload the image to our S3 bucket. The Dockerfile is here./docker/build-cache.Dockerfile
- it should be simple enough to modify the official containers in a similar manner and then the Dockerfile can be removed.test_win_x86_64-gui_wallet.py
has not been modified since CI is not setup to run it, although the same changes done totest_win_x86-gui_wallet.py
would probably work here as well.makefile.unix
has been updated since the other./wallet/makefiles*
seem to be out of date anyways (and not used)We're not aware of any issues regarding the Ledger integration so please review the code and test thoroughly. We have of course tested the integration ourselves but we might have accidentally broken some unrelated features and we don't have the full context to test the whole app thoroughly.
The CI pipeline is still running for the mentioned platforms in our fork of the repo - https://github.com/vacuumlabs/neblio/actions/runs/4741911630 - the binaries will be uploaded once it finishes. (Here's a CI run from without the last commit which has the binaries already uploaded)