Retry CommonNamespaceIdentifier #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony Floeder <[email protected]>
ajfloeder
force-pushed
the
retryIdentifyCommonNamespace
branch
from
a5f1fbf to
d6b580c
Compare
roehrich-hpe
approved these changes
Jun 20, 2023
bdevcich
reviewed
Jun 20, 2023
| var err error | ||
| ns, err = s.device.IdentifyNamespace(CommonNamespaceIdentifier) | ||
| if err != nil { | ||
| if retryCount >= 2 { |
There was a problem hiding this comment.
Any reason this should be configurable?
There was a problem hiding this comment.
Leaving this alone for now to address other issues.
bdevcich
approved these changes
Jun 20, 2023
…eady exist Signed-off-by: Anthony Floeder <[email protected]>
bdevcich
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry
identify common namespaceduring initialization to recover from intermittent failures seen during power cycle testing.