Bug/stoneship #82
Merged
Bug/stoneship #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ercycle Signed-off-by: Anthony Floeder <[email protected]>
…iveFirmware.sh script to program drive firmware Signed-off-by: Anthony Floeder <[email protected]>
matthew-richerson
approved these changes
Apr 12, 2023
bdevcich
reviewed
Apr 12, 2023
|
|
||
| # Create an LVM volume from the namespaces present | ||
| # shellcheck disable=SC2029 |
There was a problem hiding this comment.
No, I use shellcheck to lint my scripts. This comment tells shellcheck to avoid giving me the SC2029 warning for the line below.
bdevcich
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tim need the updateDriveFirmware script to program drive firmware in the factory.
I made a change in the nvme facilitator script to run operations on each switch in parallel to get things moving more quickly.
Finally, I changed the name of the directory from chassis-manager scripts to admin-node scripts to indicate the correct source machine to run them from.