RABSW-587: Support for retryable errors. Don't hang file share create #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 5, 2023 12:07
Signed-off-by: Nate Thornton <[email protected]>
Signed-off-by: Nate Thornton <[email protected]>
NateThornton
requested review from
ajfloeder,
matthew-richerson,
roehrich-hpe and
bdevcich
bdevcich
reviewed
Jan 6, 2023
pkg/ec/error.go
Outdated
| return e.statusCode != http.StatusTooManyRequests | ||
| } | ||
|
|
||
| func (e *ControllerError) RetryDelay() int { |
There was a problem hiding this comment.
This isn't actually used anywhere, is it?
There was a problem hiding this comment.
No, not yet. But IsRetryable() and RetryDelay() are for nnf-sos to consume
bdevcich
approved these changes
Jan 6, 2023
ajfloeder
reviewed
Jan 6, 2023
pkg/ec/error.go
Outdated
| err error | ||
| Event interface{} | ||
| statusCode int | ||
| retryDelayInSeconds int |
There was a problem hiding this comment.
Does a negative value make sense here? Maybe unsigned?
There was a problem hiding this comment.
Excellent idea! time.Duration would be best, then I can drop the units too!
Signed-off-by: Nate Thornton <[email protected]>
ajfloeder
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nate Thornton [email protected]