Tools directory changes: #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add readme.md demonstrating expected tool script usage for namespace manipulation - Add examples to nvme.sh - Extend create-write-delete.sh to format the namespace before deleting the namespace to see if delete_ns speeds up. Signed-off-by: Anthony Floeder <[email protected]> Add readme.md that demonstrates usage Signed-off-by: Anthony Floeder <[email protected]>
ajfloeder
requested review from
NateThornton,
bdevcich,
billhpe and
matthew-richerson
billhpe
approved these changes
Sep 30, 2022
tools/nvme.sh
Outdated
| ./nvme.sh -t delete 1 | ||
| ./nvme.sh cmd id-ctrl | grep -E "^fr " # firmware level | ||
| ./nvme.sh cmd id-ctrl | grep -E "^mn " # model name | ||
| ./nvme.sh cmd format -f -n <namespace id> # format specified namespace |
There was a problem hiding this comment.
Please use long form names so they are not as cryptic to the reader
bdevcich
reviewed
Oct 5, 2022
| @@ -57,6 +57,17 @@ case "$SIZE" in | |||
| # Delete the logical volume to tidy up | |||
| ./lvm.sh delete | |||
|
|
|||
| # Format the namespace to speed up deletion | |||
| ./nvme.sh cmd format -f -n 1 | |||
bdevcich
reviewed
Oct 5, 2022
tools/readme.md
Outdated
| ## Example script to walk the cycle | ||
|
|
||
| ```bash | ||
| create-write-delete-namespaces.sh* |
There was a problem hiding this comment.
do you want the wild card at the end?
bdevcich
approved these changes
Oct 5, 2022
Signed-off-by: Anthony Floeder <[email protected]>
ajfloeder
force-pushed
the
bugfix/readme-and-nvme-enhancements
branch
from
1a8978f to
ce0ed49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anthony Floeder [email protected]
Add readme.md that demonstrates usage
Signed-off-by: Anthony Floeder [email protected]