Requirements for Prometheus #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-richerson
approved these changes
Nov 6, 2023
| @@ -205,10 +205,10 @@ uninstall: manifests kustomize ## Uninstall CRDs from the K8s cluster specified | |||
| $(KUSTOMIZE) build config/crd | kubectl delete --ignore-not-found -f - | |||
|
|
|||
| deploy: kustomize edit-image ## Deploy controller to the K8s cluster specified in ~/.kube/config. | |||
| $(KUSTOMIZE) build config/begin | kubectl apply -f - | |||
| ./deploy.sh deploy $(KUSTOMIZE) config/begin | |||
There was a problem hiding this comment.
On the "deploy" lines, the "config/begin" isn't used because it's hard coded into the deploy.sh script. Does it have to be included on this line? Same for all the other PRs too.
There was a problem hiding this comment.
I hadn't meant for it to be hardcoded. I'll adjust that.
ajfloeder
approved these changes
Nov 6, 2023
Add a label to the ServiceMonitor resource that will be common across all DWS and NNF repos so we can easily tell Prometheus which ones it should select. Copy the namespace value into config/prometheus so that part of config/ can be deployed on its own. Add a ClusterRoleBinding that can be used by a metrics reader process to debug the metrics endpoint of the controller. The ClusterRole is already being installed, and the ServiceAccount is already installed. Introduce a deploy.sh script for the "make deploy" and "make undeploy" targets. This script will do the usual deploy/undeploy, but will also determine whether or not the ServiceMonitor resource can be applied. Signed-off-by: Dean Roehrich <[email protected]>
roehrich-hpe
force-pushed
the
prometheus-requirements
branch
from
b0601cb to
206526a
Compare
Signed-off-by: Dean Roehrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a label to the ServiceMonitor resource that will be common across all DWS and NNF repos so we easily tell Prometheus which ones it should select.
Copy the namespace value into config/prometheus so that part of config/ can be deployed on its own.
Add a ClusterRoleBinding that can be used by a metrics reader process to debug the metrics endpoing of the controller. The ClusterRole is already being installed, and the ServiceAccount is already installed.
Introduce a deploy.sh script for the "make deploy" and "make undeploy" targets. This script will do the usuall deploy/undeploy, but will also determine whether or not the ServiceMonitor resource can be applied.