Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethereum: Validate valid_till_block_height #68

Merged
merged 8 commits into from
Apr 25, 2023

Conversation

karim-en
Copy link
Collaborator

@karim-en karim-en commented Apr 20, 2023

Add valid_till_block_height argument to the transferTokens to avoid applying stuck/delayed transactions from mempool.

Note: the relayer is needed to be updated.

@karim-en karim-en changed the title Validate valid till block height Ethereum: Validate valid till block height Apr 20, 2023
eth/contracts/EthErc20FastBridge.sol Outdated Show resolved Hide resolved
eth/res/EthErc20FastBridge_flat.sol Outdated Show resolved Hide resolved
eth/test/bridge.test.js Outdated Show resolved Hide resolved
eth/contracts/EthErc20FastBridge.sol Outdated Show resolved Hide resolved
eth/res/EthErc20FastBridge_flat.sol Outdated Show resolved Hide resolved
eth/test/bridge.test.js Outdated Show resolved Hide resolved
eth/test/bridge.test.js Outdated Show resolved Hide resolved
eth/test/bridge.test.js Outdated Show resolved Hide resolved
@sept-en sept-en changed the title Ethereum: Validate valid till block height Ethereum: Validate valid_till_block_height Apr 25, 2023
Copy link
Contributor

@UrAvgDeveloper UrAvgDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sept-en sept-en merged commit a32f57e into master Apr 25, 2023
@sept-en sept-en deleted the validate-valid-till-block branch April 25, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants