Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scripts to deploy, upgrade and interact with EthErc20FastBridge #28

Merged
merged 17 commits into from
Jun 8, 2023
Merged

Add scripts to deploy, upgrade and interact with EthErc20FastBridge #28

merged 17 commits into from
Jun 8, 2023

Conversation

UrAvgDeveloper
Copy link
Contributor

No description provided.

@sept-en sept-en requested review from sept-en and karim-en January 11, 2023 02:32
sept-en
sept-en suggested changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@sept-en sept-en left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I added some comments.
Also, please add scripts for all the available getters in the contract.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
eth/scripts/EthErc20FastBridge/deploy_bridge_proxy.js Outdated Show resolved Hide resolved
eth/scripts/EthErc20FastBridge/pause_unpause.js Outdated Show resolved Hide resolved
eth/scripts/EthErc20FastBridge/upgrade_bridge.js Outdated Show resolved Hide resolved
eth/scripts/EthErc20FastBridge/upgrade_bridge.js Outdated Show resolved Hide resolved
eth/scripts/EthErc20FastBridge/upgrade_bridge.js Outdated Show resolved Hide resolved
eth/scripts/EthErc20FastBridge/whitelistTokens.js Outdated Show resolved Hide resolved
eth/scripts/EthErc20FastBridge/whitelistTokens.js Outdated Show resolved Hide resolved
eth/scripts/EthErc20FastBridge/withdraw_Stuck_tokens.js Outdated Show resolved Hide resolved
@sept-en sept-en requested a review from olga24912 January 18, 2023 12:41
olga24912
olga24912 requested changes Jan 18, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
karim-en
karim-en requested changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@karim-en karim-en left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comments, I recommend using hardhat tasks instead of scripts if there are arguments.

eth/scripts/EthErc20FastBridge/upgrade_bridge.js Outdated Show resolved Hide resolved
eth/package.json Outdated Show resolved Hide resolved
olga24912
olga24912 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@olga24912 olga24912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the place for documentation improvement, but I think it is not super important right now. I can do it by myself in the next PR. The most important part is that it is clear now how to use each method :)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
UrAvgDeveloper and others added 2 commits January 23, 2023 18:04
@UrAvgDeveloper @olga24912
Update README.md
565837b 
Co-authored-by: Olga Kunyavskaya <[email protected]>
@UrAvgDeveloper @olga24912
Update README.md
707e96a 
Co-authored-by: Olga Kunyavskaya <[email protected]>
@sept-en
Copy link
Contributor

sept-en commented May 16, 2023

@UrAvgDeveloper could you please resolve conflicts?

sept-en
sept-en suggested changes Jun 8, 2023
View reviewed changes
eth/hardhat.config.js Show resolved Hide resolved
eth/hardhat.config.js Show resolved Hide resolved
eth/hardhat.config.js Show resolved Hide resolved
eth/hardhat.config.js Show resolved Hide resolved
eth/hardhat.config.js Show resolved Hide resolved
eth/scripts/EthErc20FastBridge/upgrade_bridge.js Outdated Show resolved Hide resolved
eth/scripts/EthErc20FastBridge/whitelistTokens.js Show resolved Hide resolved
eth/package.json Show resolved Hide resolved
eth/scripts/EthErc20FastBridge/deploy_and_verify_bridge.js Show resolved Hide resolved
eth/scripts/EthErc20FastBridge/interact_with_bridge.js Show resolved Hide resolved
@sept-en sept-en mentioned this pull request Jun 8, 2023
Open
@sept-en sept-en changed the title add scripts to deploy, upgrade and interact with EthErc20FastBridge Add scripts to deploy, upgrade and interact with EthErc20FastBridge Jun 8, 2023
@sept-en sept-en merged commit c1039b5 into master Jun 8, 2023
@sept-en sept-en deleted the EthErc20FastBridge-scripts branch June 8, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karim-en karim-en karim-en approved these changes

@olga24912 olga24912 olga24912 approved these changes

@sept-en sept-en sept-en approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UrAvgDeveloper @sept-en @olga24912 @karim-en