Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix spinner keeps spinning #2194

Merged
merged 1 commit into from
Nov 1, 2023
Merged

fix spinner keeps spinning #2194

merged 1 commit into from
Nov 1, 2023

Conversation

marunjar
Copy link
Collaborator

  • hide spinner if Searcher is cancelled
  • refactor displayLoader
    • cancel running animation if necessary to not interfer with new spinner visibility
    • always set proper alpha value
  • should mitigate Bug that appears only when loading Kiss Launcher #2060, although loading sometimes just takes a long time

@marunjar
spinner is spinning
9087b94 
- mitigates Neamar#2060
- hide spinner if `Searcher` is cancelled
- refactor `displayLoader`
  - cancel running animation if necessary to not interfer with new state
  - always set proper alpha value
@marunjar marunjar changed the title spinner is spinning fix spinner keeps spinning Oct 26, 2023
@marunjar marunjar marked this pull request as ready for review November 1, 2023 20:44
@marunjar marunjar merged commit 8fc115f into Neamar:master Nov 1, 2023
@marunjar marunjar deleted the fix_spinner branch November 1, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marunjar