Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: User can select which apps can show shortcuts #2025

Merged
merged 8 commits into from
Dec 29, 2022

Conversation

LukeNeedham
Copy link
Contributor

Hi there, thanks for this great launcher. Been using it every day for the past 5 years and loving it! Thought it was time to give back ;-)

This is a use-case I personally have wanted for a while. In my case, I like having app shortcuts available in KISS for some apps, but not other apps. In particular, I've been wanting to get rid of the shortcuts from Spotify for a long time. This new feature makes that possible.

Resolved issues:

Possibly resolved issues:

The user can select which apps are allowed to display shortcuts using a new settings sub-page, using the existing ExcludePreferenceScreen. The excluded apps are stored in a StringSet in the SharedPreferences, in a similar way to how excluding apps from history works. Upon excluding / including an app, the shortcuts automatically refresh.

Within 'Seach Settings', a new 'View or edit apps excluded from shortcuts' button has been added directly below the 'Shortcuts' switch. This button is added asynchronously:

image

Clicking that button brings you to this familiar UI:

image

Note that by default, no apps are excluded from showing shortcuts - not even KISS launcher itself.

The 'Shortcuts' switch still has ultimate power - if the switch is 'off', no shortcuts will show. If the switch is 'on', shortcuts will show for all the apps which aren't in the excluded list.

Tested on:

  • API 22 (emulator) - does nothing, because shortcuts are no supported, but the UI in the settings still shows (similar to existing shortcuts switch)
  • API 27 (physical) - works as expected
  • API 32 (emulator) - works as expected

Copy link
Collaborator

@marunjar marunjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found only a few small things that could be discussed.
All in all: thx for this MR, i like this feature.

app/src/main/java/fr/neamar/kiss/SettingsActivity.java Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/xml/preferences.xml Show resolved Hide resolved
@Neamar
Copy link
Owner

Neamar commented Dec 16, 2022

API 22 (emulator) - does nothing, because shortcuts are no supported, but the UI in the settings still shows (similar to existing shortcuts switch)

Would it make sense to hide both switches? Probably makes for a better UX :)

Also, sorry, some conflicts were created recently, if you don't mind having a look!

Overall, I like the idea too

@LukeNeedham
Copy link
Contributor Author

Thanks for the quick reviews guys. I'll have time to take a look and make changes on Sunday. Fingers crossed we can still be on time to make this feature someone's christmas present ;-)

@LukeNeedham
Copy link
Contributor Author

API 22 (emulator) - does nothing, because shortcuts are no supported, but the UI in the settings still shows (similar to existing shortcuts switch)

Would it make sense to hide both switches? Probably makes for a better UX :)

Agreed, will change this too

@LukeNeedham
Copy link
Contributor Author

Sorry for the delay getting back to this, but I've addressed all your comments now. Let me know what you think!

@marunjar
Copy link
Collaborator

@LukeNeedham @Neamar MR looks good to me 👍

@Neamar
Copy link
Owner

Neamar commented Dec 29, 2022

Thanks for your contribution!

@Neamar Neamar merged commit fc96f7a into Neamar:master Dec 29, 2022
@user451421541757324
Copy link

@Neamar I saw a new release on Play Store with this feature not included. Does that mean Play Store users will have to wait months before they see this feature?

@Neamar
Copy link
Owner

Neamar commented Dec 29, 2022

Beta channel has the new feature already,

On the other hand, production release was bumped out to v3.17 after weeks of testing and fixes.

If you want the new feature already, join the beta channel and you'll get it now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants