Fix bug in parallelized closed-loop plume tracking #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point we made the run_simulation function return the Simulation object to facilitate testing. However this broke the parallel execution of the code because parallelization (at least via joblib) pickles the returned object in the reduce step. However, the Simulation object is not pickle-able.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At some point we made the
run_simulationfunction return the Simulation object to facilitate testing. However this broke the parallel execution of the code because parallelization (at least via joblib) pickles the returned object in the reduce step. However, the Simulation object is not pickle-able. We now drop the returned value in the wrapper that encapsulatesrun_simulation.Does this address any currently open issues?
N/A