Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add walking controller comparison #192

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Conversation

sibocw
Copy link
Contributor

@sibocw sibocw commented Jun 17, 2024

Description

See #190 #191 trying to move the walking controller benchmark code from nmf2-paper to flygym/exanokes

Does this address any currently open issues?

[list open issues here]

@sibocw sibocw marked this pull request as ready for review June 17, 2024 20:00
@sibocw
Copy link
Contributor Author

sibocw commented Jun 18, 2024

@tkclam Thanks for pushing to this new branch

  1. I renamed ColoredFly to ColorableFly because it doesn't color the fly by itself — it just allows the user to color the fly more easily.
  2. I updated the docs and README a bit, could you please check if the information is correct?
  3. I fixed a minor IO bug in your script (wrong relative path to the individual frames).
  4. The aspect ratio of the images is a bit off (too narrow; see below). Do you know what might have caused this? Is it related to your recent changes?
controller_comparison.mp4

@sibocw sibocw requested a review from tkclam June 18, 2024 09:44
@tkclam
Copy link
Contributor

tkclam commented Jun 18, 2024

I've just pushed a commit which should fix the aspect ratio

@sibocw sibocw merged commit 19d1172 into dev-v1.0.0-pre.4 Jun 18, 2024
8 checks passed
@sibocw sibocw deleted the add-controller-comparison branch June 18, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants