-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support decoding of binary QR codes #82
Open
KlaasJelmer
wants to merge
3
commits into
NaturalHistoryMuseum:master
Choose a base branch
from
KlaasJelmer:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outofmemo
pushed a commit
to outofmemo/pyzbar
that referenced
this pull request
Apr 18, 2021
libzbar support raw binary data since 0.23.1. See more: mchehab/zbar@59e0ed1 Refer to KlaasJelmer's modification to add configuration option ZBAR_CFG_BINARY to pyzbar. See more: NaturalHistoryMuseum#82 And modify the conversion method of symbol data to support binary data.
Is there a good way to get attention to this pull request? This would be quite a nice and useful workaround for issues in Europe, where the base library zbar mis-interprets the encoding:
My workaround for now is the following, which could be avoided if one could just get the binary representation of the QR codes:
|
Getting the same issue. Hope this pull request gets more attention as soon as possible! |
seanjdunn85
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ZBar decoder encounters binary data, it guesses the data encoding while converting it to text. This behavior destroys other types of data.
Version 0.23.1 of the ZBar library supports decoding binary QR codes using configuration option
ZBAR_CFG_BINARY
. This PR allows settings this flag from thedecode()
function