-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the nativescript-floatingactionbutton module #49
Conversation
Sorry for the polluted PR, I cloned the repo with Visual Studio and it added some junk and I didn't realize it. I only added the module to the package.json file, added the ic_history.png file for the respective android app_resources folders and then updated the list.xml to use the Fab component. I understand if you think this might be too much to include in the sample, no hard feelings if you think it's best to not include it. I just prefer the native 'ripple' effect when pressing and getting rid of that fab.png image. Ping me if you want to discuss. |
Thanks @bradmartin! No worries about the extraneous files; I can always clean those up later. I’ll look at this over later today. |
</lv:rad-list-view> | ||
|
||
<android> | ||
<FabButton:fab row="1" tap="history" icon="ic_history" backColor="#336699" rippleColor="#999" class="fab-button" margin="15" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the margin
be moved to the existing .fab-button
selector in the CSS file?
backColor
would be nice to move too, but I’m guessing that one needs to be in the XML.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like yes. I’ll go ahead and update that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
margin can be moved
backColor is accessed in the plugin. I need to enhance the plugin to work with the CSS but I wrote this before I really understood how to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, you should also be able to remove the android
tags if you wanted, but sometimes it's nice to have those. Especially when starting out that's why I left them in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I’m cool with hardcoding these colors in here for now, although it’d be great if backColor
made it into CSS in a future release.
I’m going to do some git fu and merge this in now.
Merged. Thanks! 🎉 Now I need help with some checkboxes 😀 |
No description provided.