Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): add option for showing internal/external storage #302

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

xuhcc
Copy link
Contributor

@xuhcc xuhcc commented Aug 27, 2019

PR Checklist

What is the current behavior?

Internal and external storage may not be shown by default in Android file chooser.

What is the new behavior?

The new showAdvanced option forces the file chooser to show these locations. However, under the hood, it uses an undocumented android function, so the warning was added to readme.

I also removed two broken links from TOC.

@cla-bot cla-bot bot added the cla: yes label Aug 27, 2019
@tgpetrov
Copy link
Contributor

tgpetrov commented Sep 4, 2019

@xuhcc We are experiencing an issue with saucelabs where we run our tests which is the reason for their failure, as soon as we sort it out we can proceed with merging your PRs.

@tgpetrov
Copy link
Contributor

tgpetrov commented Sep 9, 2019

@xuhcc Can you rebase your branch with latest changes from master so a can merge it?

@xuhcc
Copy link
Contributor Author

xuhcc commented Sep 9, 2019

@tgpetrov Done.

@tgpetrov tgpetrov merged commit 5ac9aa7 into NativeScript:master Sep 9, 2019
@xuhcc xuhcc deleted the sd-card branch September 9, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants