Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: --gradleArgs option to pass gradle parameters #5630

Merged
merged 3 commits into from
Feb 15, 2022

Conversation

farfromrefug
Copy link
Contributor

In the same vibe as gradlePath this allows to pass gradle command parameters.
One note is that they have to be double quoted like this --gradle '"-PsplitEnabled"' or using = like this --gradle="-PsplitEnabled"
This is due to how yargs parses arguments

@rigor789 rigor789 changed the title feat: implemented --gradle option to pass gradle parameters feat: --gradleArgs option to pass gradle parameters Feb 15, 2022
@rigor789
Copy link
Member

Renamed from --gradle to --gradleArgs to better describe what the option does, and to align with the --gradlePath option.

Copy link
Member

@rigor789 rigor789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rigor789 rigor789 merged commit 02d179a into NativeScript:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants