Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android App Bundle Improvements #5049

Closed
DimitarTachev opened this issue Oct 7, 2019 · 2 comments
Closed

Android App Bundle Improvements #5049

DimitarTachev opened this issue Oct 7, 2019 · 2 comments
Assignees
@DimitarTachev
Labels
feature
Milestone
6.2.0

Comments

@DimitarTachev
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The Android App Bundle (+ snapshot and libs) is not well-documented and it requires a few manual steps.

Describe the solution you'd like
The Android App Bundle should be fully automated and well-documented.
@DimitarTachev DimitarTachev self-assigned this Oct 7, 2019
DimitarTachev pushed a commit to NativeScript/android that referenced this issue Oct 9, 2019
feat: support snapshot libs out of the box
4a54091 
In this way, we avoid the manual step when a snapshot build with `useLibs` is generated.

* This should not affect the default builds as the additional folder does not exist.

Related to: NativeScript/nativescript-cli#5049
This was referenced Oct 9, 2019
Merged
Merged
Merged
@DimitarTachev
Copy link
Contributor Author

DimitarTachev commented Oct 11, 2019 •
edited by endarova
Loading

Acceptance Criteria (should be tested in a newly created JavaScript app):

  • The old useLibs SnapshotPlugin setting should be exposed as --env.compileSnapshot
  • The Android NDK should not be required in the webpack.config when providing --env.compileSnapshot. We should support the following installations:
  1. From the webpack.config (backwards compatibility)
  2. When the ANDROID_NDK_HOME env variable is set
  3. ndk-build available globally (ndk home dir is in PATH)
  4. Downloaded through Android Studio.
  • The used ndk-build should be logged to the console (one of the 4 locations mentioned in the above AC).
  • If the locally available ndk-build revision is different than the one used in the Android Runtime, a warning should be shown without exiting the build.
  • If the ndk-build is used globally from PATH, an unknown version info message should be shown without exiting the build.
  • Providing --env.snapshot, --end.compileSnapshot and --aab should be the minimum setup of running the app if the Android NDK is locally available and tns-android >= 6.2.0.
  • Before [email protected], the sourceSets section of App_Resources/android/app.gradle should still be required.
  • Specifying architectures will be supported in the App_Resources/android/app.gradle by providing android.defaultConfig.ndk.abiFilters and it should be described in the docs.
  • The --aab should be supported on tns run, tns debug, tns test and tns deploy when the connected device/emulator is with API level 19+.
  • The --aab should be supported on tns cloud run --release with an additional JAVA requirement.

@DimitarTachev DimitarTachev mentioned this issue Oct 15, 2019
Merged
5 tasks
This was referenced Oct 16, 2019
Merged
Merged
@endarova
Copy link
Contributor

endarova commented Oct 18, 2019 •
edited
Loading

#5089

This was referenced Oct 28, 2019
Merged
Merged
@Fatme Fatme added the feature label Nov 1, 2019
@Fatme Fatme added this to the 6.2.0 milestone Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitarTachev DimitarTachev

Labels
feature
Projects
None yet
Milestone
6.2.0
Development

No branches or pull requests
3 participants
@Fatme @DimitarTachev @endarova