Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button listener missing owner #4897

Closed
hshristov opened this issue Sep 27, 2017 · 1 comment · Fixed by #4898
Closed

Button listener missing owner #4897

hshristov opened this issue Sep 27, 2017 · 1 comment · Fixed by #4898
Assignees
@hshristov
Labels
bug os: android severity: medium
Milestone
3.3

Comments

@hshristov
Copy link
Contributor

If you add tap gesture on a button parent (e.g. some layout for example), add tap handler on the button, click the button and execute navigation with clear history current fragment will be removed and we will clear the button listener owner. Still android will fire the click handler and we will throw an exception.
@hshristov hshristov added this to the 3.3 (TBD) milestone Sep 27, 2017
@hshristov hshristov self-assigned this Sep 27, 2017
hshristov pushed a commit that referenced this issue Sep 27, 2017
If you set tap gesture on a button parent (e.g. some layout for examp…
9664bbe 
…le) and set tap handler on the button and click the button there is a chance to execute navigation with clear history. This will remove current fragment and will clear the button listener owner. Still android will fire the click handler and we will throw an exception.

Fix #4897
@hshristov hshristov mentioned this issue Sep 27, 2017
Merged
hshristov pushed a commit that referenced this issue Sep 28, 2017
If you set tap gesture on a button parent (e.g. some layout for examp…
9b52bbc 
…le) and set tap handler on the button and click the button there is a chance to execute navigation with clear history. This will remove current fragment and will clear the button listener owner. Still android will fire the click handler and we will throw an exception. (#4898)

Fix #4897
@lock
Copy link

lock bot commented Aug 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hshristov hshristov

Labels
bug os: android severity: medium
Projects
None yet
Milestone
3.3
Development

Successfully merging a pull request may close this issue.

Added check for owner in button listener NativeScript/NativeScript
1 participant
@hshristov