Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron refactor symlink and webpack #392

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

electron refactor symlink and webpack #392

wants to merge 18 commits into from

Conversation

Kaffiend
Copy link
Contributor

Working on a overhauled concept of the approach the seed has for building electron.

As awesome as this seed is, I feel the electron aspect is in need of some attention, hopefully fully embracing electron's capabilities and simplifying the development process while sharing code base.

I'm attempting to take a similar approach to Electron as was done with Nativescript implementation, as electron is web technology on the desktop, electron is not the web, hopefully this opens things up and makes it easier.

Any help, advice, or insight is most welcome.

I've "speculated" a checklist in an issue on the fork here.

@NathanWalker
Copy link
Owner

This is very smart @Kaffiend 👍 👍 👍
I've always strived to keep it in with web for simplicity but it deserves it own place amongst the platform players to make it truly scalable. As long as code sharing is maximized is the end goal.

@Kaffiend
Copy link
Contributor Author

failed because the webpack build expects the stylesheets in the component to be the same as the actual file, not the output file type of CSS after compilation. Going to need to write a helper or custom loader...maybe

@NathanWalker
Copy link
Owner

@Kaffiend looks like the build has passed - what are your thoughts on this at the moment?

@Kaffiend
Copy link
Contributor Author

Kaffiend commented Apr 4, 2017

@NathanWalker the build passed but its not ready yet. I need to find some time to get to the last build task and try to understand the custom loader a little better, didnt get to spend much time on it this weekend. The loader is my current obstacle.

@NathanWalker
Copy link
Owner

Totally understand, loader can be tricky - great effort here.

@Kaffiend
Copy link
Contributor Author

I havent forgotten about this, just not much time of late. Any help would be much appreciated.

@Kaffiend
Copy link
Contributor Author

Kaffiend commented Jan 12, 2018

Working on a seed of my own lately and I think with what I've learned with it, I can give this PR a little more love.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants