pkp/pkp-lib#5122 Use Countable interface in DAOResultIterator

NateWr · Oct 22, 2019 · 6b00d35 · 6b00d35
1 parent 5e34d67
commit 6b00d35
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/api/v1/issues/IssueHandler.inc.php b/api/v1/issues/IssueHandler.inc.php
@@ -169,7 +169,7 @@ public function getMany($slimRequest, $response, $args) {
 
 		$items = array();
 		$result = $issueService->getMany($params);
-		if ($result->valid()) {
+		if (count($result)) {
 			$propertyArgs = array(
 				'request' => $request,
 				'slimRequest' => $slimRequest,

diff --git a/classes/components/forms/site/SiteConfigForm.inc.php b/classes/components/forms/site/SiteConfigForm.inc.php
@@ -46,7 +46,7 @@ public function __construct($action, $locales, $site) {
 			'value' => $site->getData('title'),
 		]));
 
-		if ($result->valid()) {
+		if (count($result)) {
 			$options = [['value' => '', 'label' => '']];
 			foreach ($result as $context) {
 				$options[] = [

diff --git a/pages/article/ArticleHandler.inc.php b/pages/article/ArticleHandler.inc.php
@@ -70,7 +70,7 @@ function initialize($request, $args = array()) {
 			'publisherIds' => $urlPath,
 		]);
 		$publicationWithMatchingUrl = null;
-		if ($result->valid()) {
+		if (count($result)) {
 			$publicationWithMatchingUrl = $result->current();
 			$submissionId = $publicationWithMatchingUrl->getData('submissionId');
 		} elseif (ctype_digit($urlPath)) {