Fix sidebar navigation after erroneous page #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 4ab7ba3)
Codecov Report
@@ Coverage Diff @@
## master #1196 +/- ##
============================================
- Coverage 68.91% 68.86% -0.06%
- Complexity 1592 1594 +2
============================================
Files 32 32
Lines 3912 3918 +6
============================================
+ Hits 2696 2698 +2
- Misses 1216 1220 +4
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
I've tested this and it seems to solve all three issues. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #721
Fixes #722
Fixes #723
These fixes have been split off from PR #1033 by creating a new branch from master and cherry-picking two commits by @kouralex . Some merge conflicts were fixed.