Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide translations for skosmos:marcSourceCode #1187

Merged
merged 3 commits into from
Apr 28, 2022

Conversation

kouralex
Copy link
Contributor

Fixes #1167

Whilst this fixes the aforementioned issue with the translation given in issue (note: adding a - to Finnish translation due to grammatical correctness), there exists a problem when the MARC source code value is not defined in the content language. In that case Skosmos will not show the property at all (even though it might be the default one)! I will get back to this in another PR.

@kouralex kouralex added this to the Next Tasks milestone Aug 20, 2021
@kouralex kouralex requested review from joelit and osma August 20, 2021 19:43
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #1187 (6334259) into master (964b68f) will decrease coverage by 1.45%.
The diff coverage is n/a.

❗ Current head 6334259 differs from pull request most recent head 5319920. Consider uploading reports for the commit 5319920 to get more accurate results

@@             Coverage Diff              @@
##             master    #1187      +/-   ##
============================================
- Coverage     70.36%   68.91%   -1.46%     
+ Complexity     1649     1592      -57     
============================================
  Files            32       32              
  Lines          3790     3912     +122     
============================================
+ Hits           2667     2696      +29     
- Misses         1123     1216      +93     
Impacted Files Coverage Δ
model/ConceptPropertyValueLiteral.php 62.50% <0.00%> (-7.50%) ⬇️
model/Request.php 67.85% <0.00%> (-4.06%) ⬇️
controller/RestController.php 19.45% <0.00%> (-2.94%) ⬇️
model/Concept.php 80.95% <0.00%> (-2.68%) ⬇️
model/VocabularyConfig.php 93.53% <0.00%> (-1.96%) ⬇️
model/PluginRegister.php 70.14% <0.00%> (-1.62%) ⬇️
model/ConceptSearchParameters.php 84.26% <0.00%> (-1.29%) ⬇️
controller/WebController.php 16.93% <0.00%> (-0.28%) ⬇️
controller/EntityController.php 0.00% <0.00%> (ø)
model/ConceptPropertyValue.php 86.74% <0.00%> (+0.49%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 964b68f...5319920. Read the comment docs.

@osma osma self-assigned this Apr 28, 2022
@osma osma added the bug label Apr 28, 2022
@osma osma modified the milestones: Next Tasks, 2.15 Apr 28, 2022
@osma osma changed the title provide translations for skosmos:marcSourceCode; fixes #1167 provide translations for skosmos:marcSourceCode Apr 28, 2022
@osma osma merged commit 58d75db into master Apr 28, 2022
@osma osma deleted the issue1167-translate-marcsourcecode branch April 28, 2022 14:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User-interface: Label for the property SKOSMOS:MARCSOURCECODE in the vocabulary view
2 participants