Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GitHub Actions CI #1168

Merged
merged 7 commits into from
May 27, 2021
Merged

Switch to GitHub Actions CI #1168

merged 7 commits into from
May 27, 2021

Conversation

osma
Copy link
Member

@osma osma commented May 26, 2021

This PR switches to GitHub Actions CI instead of Travis CI. This is a rework of PR #1163, which got quite messy.

Fixes #1147

TODO items:

  • Use the same PHPUnit version as declared in composer.json
  • Cache the Composer dependencies
  • Install Fuseki and load the test vocabularies into it
  • Cache the Fuseki installation
  • Run the tests on all supported PHP versions in parallel
  • Report code coverage to Code Climate
  • Report code coverage to Codecov
  • Report passing/failing tests to Slack

There is a networking issue in the php-actions/phpunit Action that this workflow relies on. This has been fixed in my fork but my PR for fixing it hasn't yet been accepted upstream. So for now this CI configuration is relying on the forked version.

This is now using the PCOV PHP extension to collect coverage information, instead of phpdbg that was used on Travis CI. PCOV is both faster and more accurate so this is clearly a win. Also, the Fuseki version has been upgraded to 4.0.0.

A few times the Fuseki installation step has been stuck. I don't know what is causing it but others have reported similar problems so it could be a more general problem with Actions. If this happens the job can be restarted (though canceling also seems to get stuck).

@osma osma added this to the 2.11 milestone May 26, 2021
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #1168 (76ba984) into master (4b538db) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1168      +/-   ##
============================================
+ Coverage     67.97%   68.00%   +0.02%     
  Complexity     1584     1584              
============================================
  Files            32       32              
  Lines          3888     3888              
============================================
+ Hits           2643     2644       +1     
+ Misses         1245     1244       -1     
Impacted Files Coverage Δ
model/BaseConfig.php 71.42% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b538db...76ba984. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@osma osma merged commit 1a7f7be into master May 27, 2021
@osma osma deleted the issue1147-github-actions branch May 27, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from Travis CI to GitHub Actions
1 participant