-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to GitHub Actions CI #1168
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1168 +/- ##
============================================
+ Coverage 67.97% 68.00% +0.02%
Complexity 1584 1584
============================================
Files 32 32
Lines 3888 3888
============================================
+ Hits 2643 2644 +1
+ Misses 1245 1244 -1
Continue to review full report at Codecov.
|
osma
commented
May 27, 2021
osma
commented
May 27, 2021
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches to GitHub Actions CI instead of Travis CI. This is a rework of PR #1163, which got quite messy.
Fixes #1147
TODO items:
There is a networking issue in the php-actions/phpunit Action that this workflow relies on. This has been fixed in my fork but my PR for fixing it hasn't yet been accepted upstream. So for now this CI configuration is relying on the forked version.
This is now using the PCOV PHP extension to collect coverage information, instead of phpdbg that was used on Travis CI. PCOV is both faster and more accurate so this is clearly a win. Also, the Fuseki version has been upgraded to 4.0.0.
A few times the Fuseki installation step has been stuck. I don't know what is causing it but others have reported similar problems so it could be a more general problem with Actions. If this happens the job can be restarted (though canceling also seems to get stuck).