Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom types in data structures and constants #1

Closed
wants to merge 7 commits into from

Conversation

Nashatyrev
Copy link
Owner

Original issue: ethereum#667

The goal is to improve Spec readability by using alias custom types in data structures and as constant units instead of generic types.

What was done

  • Add Hash and Bitfield custom types. The Hash type is treated as a result of any 256-bit cryptographic hash function or its derivative preserving hash properties (like xoring two hashes)
  • Replace generic SSZ types in data structures with custom types where appropriate
  • Add/update constant units according to custom types

What else can be done

@mkalinin
Copy link

LGTM! 👍

@Nashatyrev Nashatyrev closed this Feb 27, 2019
@Nashatyrev Nashatyrev deleted the feature/struct-custom-types branch February 27, 2019 07:20
@Nashatyrev Nashatyrev restored the feature/struct-custom-types branch February 27, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants