Use custom types in data structures and constants #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue: ethereum#667
The goal is to improve Spec readability by using alias custom types in data structures and as constant units instead of generic types.
What was done
Hash
andBitfield
custom types. TheHash
type is treated as a result of any 256-bit cryptographic hash function or its derivative preserving hash properties (likexor
ing two hashes)What else can be done
Time
,ForkVersion
,Bitfield64
) which are now referred at 1-2 places in the Spec'validator_balances': [ValidatorIndex => Gwei]
)